Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Liquibase - Record service classes implementation instead of generating a native resource file for each service interface #8116

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Liquibase - Record service classes implementation instead of generating a native resource file for each service interface #8116

merged 1 commit into from
Apr 14, 2020

Conversation

machi1990
Copy link
Member

This cleans up the extension processing part a little bit as we can record these info in a registry
and do a map lookup during runtime instead of reading the generated resource file for each service
class

Follows up this #8065 (comment) comment.

@machi1990 machi1990 changed the title refactor(liquibase): record service classes implementation instead of generating a native resource file for each service interface record service classes implementation instead of generating a native resource file for each service interface Mar 24, 2020
@machi1990 machi1990 requested a review from gsmet March 24, 2020 17:36
@gsmet gsmet changed the title record service classes implementation instead of generating a native resource file for each service interface Liquibase - Record service classes implementation instead of generating a native resource file for each service interface Mar 24, 2020
@gsmet gsmet added this to the 1.4.0 milestone Mar 24, 2020
@gastaldi gastaldi added the kind/enhancement New feature or request label Mar 25, 2020
@gastaldi
Copy link
Contributor

I'll let @gsmet review and merge

@machi1990
Copy link
Member Author

Thanks @gastaldi

@machi1990 machi1990 added the triage/needs-rebase This PR needs to be rebased first because it has merge conflicts label Apr 3, 2020
@machi1990 machi1990 force-pushed the refactor/review-service-locators-scanning-for-liquibase-extension branch from 0ef1b61 to 9aba6b4 Compare April 3, 2020 16:09
@machi1990 machi1990 removed the triage/needs-rebase This PR needs to be rebased first because it has merge conflicts label Apr 3, 2020
@machi1990 machi1990 force-pushed the refactor/review-service-locators-scanning-for-liquibase-extension branch from 9aba6b4 to 7029e5d Compare April 8, 2020 16:02
@machi1990 @gsmet
refactor(liquibase): record service classes implementation instead of…
074168d 
… generating a native resource file for each service interface

This cleans up the extension processing part a little bit as we can record these info in a registry
and do a map lookup during runtime instead of reading the generated resource file for each service
class
@gsmet gsmet force-pushed the refactor/review-service-locators-scanning-for-liquibase-extension branch from 7029e5d to 074168d Compare April 14, 2020 17:52
@gsmet
Copy link
Member

gsmet commented Apr 14, 2020

I rebased it, let's wait for CI.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 14, 2020
@gsmet gsmet merged commit 7894a22 into quarkusio:master Apr 14, 2020
@machi1990 machi1990 deleted the refactor/review-service-locators-scanning-for-liquibase-extension branch April 14, 2020 19:29
@vsevel vsevel mentioned this pull request Apr 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
kind/enhancement New feature or request triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.4.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@machi1990 @gastaldi @gsmet